[Spec] Add directFromSellerSignals #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@domfarolino Can you take a look? The TODO will go away once I integrate with the changes @qingxinwu is working on, but I'd like feedback especially on how I did the fetch spec integration. |
@qingxinwu 's code is in #774, just need to integrate the two. |
domfarolino
reviewed
Sep 4, 2023
qingxinwu
reviewed
Sep 8, 2023
domfarolino
reviewed
Sep 13, 2023
qingxinwu
reviewed
Sep 28, 2023
domfarolino
reviewed
Oct 2, 2023
domfarolino
reviewed
Oct 11, 2023
domfarolino
reviewed
Oct 12, 2023
domfarolino
approved these changes
Oct 13, 2023
|
Thanks @domfarolino for all the reviews! I learned a lot :) |
github-actions bot
added a commit
that referenced
this pull request
Oct 13, 2023
SHA: 1a537b6 Reason: push, by JensenPaul Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for review
Preview | Diff